1e9481849b
Sweep across the three script directories: features/scripts/utils,
core/system/scripts, themes/engine/scripts. 142 of 169 bash scripts
gained `set -e`; 27 already had it; the one Python helper
(nomarchy-haptic-touchpad) was skipped via shebang detection.
Why: bash's default behavior is to continue past a failed command,
which means a script that does "do A; do B; do C" leaves the system
in a half-applied state when B fails - and the user gets no signal.
Several recent fix commits (theme partial-apply, waybar reload race,
installer prewipe silent failures) all trace back to this. set -e
turns silent corruption into a loud abort the user can act on.
The 11 scripts with explicit `|| true` markers stay safe under set -e
because || true coerces the exit to zero; the markers continue to
mean "I deliberately tolerate this failure here."
Deliberate exception: nomarchy-menu runs WITHOUT set -e. It is an
interactive UX loop where action branches do `cmd; back_to <self>`
so a failed action would abort the script under set -e and the menu
would disappear without feedback. Soft-failure - menu re-displays,
user picks again - is the right semantic. Documented inline.
Validation: bash -n on every modified script (zero failures). The
new pre-commit hook (27f5663) was just updated to filter by shebang
so it doesn't try to bash-syntax-check the Python helper - that
filter was uncovered by this sweep.
Risk: set -e can surface latent bugs in scripts that previously
relied on silent continuation. If anything breaks, it's a real bug
that was already broken and is now visible. Easy per-script revert
if any UX glitches show up.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
29 lines
750 B
Bash
Executable File
29 lines
750 B
Bash
Executable File
#!/usr/bin/env bash
|
|
set -e
|
|
|
|
PKG_NAME="$1"
|
|
|
|
if [ -z "$PKG_NAME" ]; then
|
|
echo "Usage: nomarchy-pkg-add <package-name>"
|
|
exit 1
|
|
fi
|
|
|
|
STATE_FILE="$HOME/.config/home-manager/user-packages.json"
|
|
mkdir -p "$(dirname "$STATE_FILE")"
|
|
|
|
if [ ! -f "$STATE_FILE" ]; then
|
|
echo "[]" > "$STATE_FILE"
|
|
fi
|
|
|
|
if jq -e --arg pkg "$PKG_NAME" '. | index($pkg)' "$STATE_FILE" >/dev/null; then
|
|
echo "Package $PKG_NAME is already in your user-packages.json"
|
|
exit 0
|
|
fi
|
|
|
|
# Append package to the JSON array safely
|
|
jq --arg pkg "$PKG_NAME" '. + [$pkg]' "$STATE_FILE" > "${STATE_FILE}.tmp" && mv "${STATE_FILE}.tmp" "$STATE_FILE"
|
|
|
|
echo "Package $PKG_NAME added declaratively to $STATE_FILE."
|
|
echo "Applying changes with nomarchy-env-update..."
|
|
nomarchy-env-update
|