1e9481849b
Sweep across the three script directories: features/scripts/utils,
core/system/scripts, themes/engine/scripts. 142 of 169 bash scripts
gained `set -e`; 27 already had it; the one Python helper
(nomarchy-haptic-touchpad) was skipped via shebang detection.
Why: bash's default behavior is to continue past a failed command,
which means a script that does "do A; do B; do C" leaves the system
in a half-applied state when B fails - and the user gets no signal.
Several recent fix commits (theme partial-apply, waybar reload race,
installer prewipe silent failures) all trace back to this. set -e
turns silent corruption into a loud abort the user can act on.
The 11 scripts with explicit `|| true` markers stay safe under set -e
because || true coerces the exit to zero; the markers continue to
mean "I deliberately tolerate this failure here."
Deliberate exception: nomarchy-menu runs WITHOUT set -e. It is an
interactive UX loop where action branches do `cmd; back_to <self>`
so a failed action would abort the script under set -e and the menu
would disappear without feedback. Soft-failure - menu re-displays,
user picks again - is the right semantic. Documented inline.
Validation: bash -n on every modified script (zero failures). The
new pre-commit hook (27f5663) was just updated to filter by shebang
so it doesn't try to bash-syntax-check the Python helper - that
filter was uncovered by this sweep.
Risk: set -e can surface latent bugs in scripts that previously
relied on silent continuation. If anything breaks, it's a real bug
that was already broken and is now visible. Easy per-script revert
if any UX glitches show up.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
44 lines
1.3 KiB
Bash
Executable File
44 lines
1.3 KiB
Bash
Executable File
#!/bin/bash
|
|
set -e
|
|
|
|
# Adjust keyboard backlight brightness using available steps.
|
|
# Usage: nomarchy-brightness-keyboard <up|down|cycle>
|
|
|
|
direction="${1:-up}"
|
|
|
|
# Find keyboard backlight device (look for *kbd_backlight* pattern in leds class).
|
|
device=""
|
|
for candidate in /sys/class/leds/*kbd_backlight*; do
|
|
if [[ -e $candidate ]]; then
|
|
device="$(basename "$candidate")"
|
|
break
|
|
fi
|
|
done
|
|
|
|
if [[ -z $device ]]; then
|
|
echo "No keyboard backlight device found" >&2
|
|
exit 1
|
|
fi
|
|
|
|
# Get current and max brightness to determine step size.
|
|
max_brightness="$(brightnessctl -d "$device" max)"
|
|
current_brightness="$(brightnessctl -d "$device" get)"
|
|
|
|
# Calculate step as one unit (keyboards typically have discrete levels like 0-3).
|
|
if [[ $direction == "cycle" ]]; then
|
|
new_brightness=$(( (current_brightness + 1) % (max_brightness + 1) ))
|
|
elif [[ $direction == "up" ]]; then
|
|
new_brightness=$((current_brightness + 1))
|
|
(( new_brightness > max_brightness )) && new_brightness=$max_brightness
|
|
else
|
|
new_brightness=$((current_brightness - 1))
|
|
(( new_brightness < 0 )) && new_brightness=0
|
|
fi
|
|
|
|
# Set the new brightness.
|
|
brightnessctl -d "$device" set "$new_brightness" >/dev/null
|
|
|
|
# Use SwayOSD to display the new brightness setting.
|
|
percent=$((new_brightness * 100 / max_brightness))
|
|
nomarchy-swayosd-kbd-brightness "$percent"
|