fix(menu): network picker blank rows — compact mode for networkmanager_dmenu (item 22)
All checks were successful
Check / eval (push) Successful in 3m13s
All checks were successful
Check / eval (push) Successful in 3m13s
Source-read of the pinned networkmanager_dmenu 2.6.2: with compact = False (what our config.ini set) the script inserts literal empty rows as separators between the ethernet/wifi/VPN sections — the nameless entries Bernardo saw on the Latitude. compact = True drops the separators and uses the unpadded row format, which also renders better in rofi's proportional font than space-aligned columns. Known residual, documented in config comment + HARDWARE-QUEUE: a hidden-SSID AP still renders one nameless row (sec+bars only; the name dedup keeps exactly one, and no config option filters it). If the V3 retest still shows it, the follow-up is a small source patch skipping empty-name APs in create_ap_list. Verified: V0; V1 (rendered config.ini shows compact = True). Behavior needs Wi-Fi hardware — V3 queued on the Latitude. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
@@ -49,6 +49,13 @@ QA machine), the **T14s** (webcam case).
|
||||
row, dimmed inactive workspaces / muted volume visible-but-dim),
|
||||
rofi inputbar/alternate rows show text. Spot-check one dark theme
|
||||
(e.g. tokyo-night) for no visual regression in the same spots.
|
||||
- [ ] **Network menu has no blank rows** (item 22 fix, needs Wi-Fi) —
|
||||
after `home-update`, open Tools › Network: no empty separator
|
||||
rows between the ethernet/wifi/VPN sections (compact = True).
|
||||
KNOWN RESIDUAL: if exactly one nameless wifi row remains showing
|
||||
only security+bars, that's a hidden-SSID AP — config can't filter
|
||||
it; report it and the follow-up is a small source patch skipping
|
||||
empty-name APs in create_ap_list.
|
||||
- [ ] **Keyboard hotplug picker (re-verify after in-flake graduation)** —
|
||||
plug an external keyboard post-login, pick a layout in rofi, confirm
|
||||
it applies per-device only, persists in `settings.keyboard.devices`,
|
||||
|
||||
Reference in New Issue
Block a user