fix(menu): network picker blank rows — compact mode for networkmanager_dmenu (item 22)
All checks were successful
Check / eval (push) Successful in 3m13s
All checks were successful
Check / eval (push) Successful in 3m13s
Source-read of the pinned networkmanager_dmenu 2.6.2: with compact = False (what our config.ini set) the script inserts literal empty rows as separators between the ethernet/wifi/VPN sections — the nameless entries Bernardo saw on the Latitude. compact = True drops the separators and uses the unpadded row format, which also renders better in rofi's proportional font than space-aligned columns. Known residual, documented in config comment + HARDWARE-QUEUE: a hidden-SSID AP still renders one nameless row (sec+bars only; the name dedup keeps exactly one, and no config option filters it). If the V3 retest still shows it, the follow-up is a small source patch skipping empty-name APs in create_ap_list. Verified: V0; V1 (rendered config.ini shows compact = True). Behavior needs Wi-Fi hardware — V3 queued on the Latitude. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
@@ -25,14 +25,6 @@ next, in what order*.
|
||||
*Items 21–27: real-hardware QA findings from the Latitude 5410
|
||||
(Bernardo, 2026-07-04) — bugs found on metal outrank the queue.*
|
||||
|
||||
### 22. Network menu shows nameless/weird entries
|
||||
Reported: `networkmanager_dmenu` lists entries with no names (likely
|
||||
hidden-SSID APs rendered as blank rows, possibly other adapters/
|
||||
duplicate BSSIDs). Investigate its config.ini surface for filtering,
|
||||
or patch the list source; blank rows in a themed picker read as
|
||||
breakage. **Verify:** V1 (config renders) — behavior needs Wi-Fi
|
||||
hardware → V3 on the Latitude.
|
||||
|
||||
### 24. "Back" audit — every list menu ends in ↩ Back
|
||||
Reported: some submenu items/tools still lack a Back option. The "Back
|
||||
everywhere" pass covered the hand-rolled dmenu lists at the time; audit
|
||||
|
||||
@@ -49,6 +49,13 @@ QA machine), the **T14s** (webcam case).
|
||||
row, dimmed inactive workspaces / muted volume visible-but-dim),
|
||||
rofi inputbar/alternate rows show text. Spot-check one dark theme
|
||||
(e.g. tokyo-night) for no visual regression in the same spots.
|
||||
- [ ] **Network menu has no blank rows** (item 22 fix, needs Wi-Fi) —
|
||||
after `home-update`, open Tools › Network: no empty separator
|
||||
rows between the ethernet/wifi/VPN sections (compact = True).
|
||||
KNOWN RESIDUAL: if exactly one nameless wifi row remains showing
|
||||
only security+bars, that's a hidden-SSID AP — config can't filter
|
||||
it; report it and the follow-up is a small source patch skipping
|
||||
empty-name APs in create_ap_list.
|
||||
- [ ] **Keyboard hotplug picker (re-verify after in-flake graduation)** —
|
||||
plug an external keyboard post-login, pick a layout in rofi, confirm
|
||||
it applies per-device only, persists in `settings.keyboard.devices`,
|
||||
|
||||
@@ -17,6 +17,20 @@ Template:
|
||||
|
||||
---
|
||||
|
||||
## 2026-07-04 — network menu blank rows (iteration #11, item 22)
|
||||
- **Task:** BACKLOG NOW#22 — nameless entries in the network picker.
|
||||
- **Did:** read the pinned networkmanager_dmenu 2.6.2 source: with
|
||||
`compact = False` (our config!) it inserts literal empty rows as
|
||||
section separators (eth/wifi/vpn) — the systematic blank entries.
|
||||
Flipped config.ini to `compact = True` (also unpadded row format,
|
||||
better in rofi's proportional font). Hidden-SSID APs additionally
|
||||
render ONE nameless sec+bars row (dedup keeps one; not config-
|
||||
filterable) — documented, V3-gated, source-patch follow-up if seen.
|
||||
- **Verified:** V0; V1 — rendered config.ini shows compact = True.
|
||||
Behavior needs Wi-Fi hardware → V3 queued.
|
||||
- **Pending:** V3 on the Latitude (no separators; hidden-AP residual?).
|
||||
- **Next suggestion:** item 24 (Back audit) — grep-the-generated-script.
|
||||
|
||||
## 2026-07-04 — waybar/rofi palette-safe pairings (iteration #10, item 27)
|
||||
- **Task:** BACKLOG NOW#27 — generated waybar/rofi CSS invisible on
|
||||
on-surface palettes (flexoki-light runs it; summers whole-swap).
|
||||
|
||||
@@ -641,13 +641,19 @@ in
|
||||
# connection drops to nmtui in the configured terminal. force: the tool
|
||||
# writes a default config on first run, so an unmanaged file may already
|
||||
# sit at this path — we fully own it, so overwrite rather than abort.
|
||||
# compact: with False the script inserts EMPTY rows as section
|
||||
# separators (eth/wifi/vpn) — blank entries in a themed picker read as
|
||||
# breakage (item 22). True drops them and uses the unpadded row format,
|
||||
# which also sits better in rofi's proportional font than the
|
||||
# space-aligned columns. (A hidden-SSID AP still renders one nameless
|
||||
# row — sec+bars only; not filterable via config, dedup keeps one.)
|
||||
xdg.configFile."networkmanager-dmenu/config.ini" = {
|
||||
force = true;
|
||||
text = ''
|
||||
[dmenu]
|
||||
dmenu_command = rofi
|
||||
rofi_highlight = True
|
||||
compact = False
|
||||
compact = True
|
||||
wifi_chars = ▂▄▆█
|
||||
|
||||
[editor]
|
||||
|
||||
Reference in New Issue
Block a user