fix(home): drop mkDefault on home.packages — it discarded the whole app list
Some checks failed
Check / eval-and-lint (push) Has been cancelled
Some checks failed
Check / eval-and-lint (push) Has been cancelled
Chasing a "DBus.Error … name is not activatable" from notify-send (mako), the root cause turned out to be far bigger: home.packages in features/default.nix was wrapped in lib.mkDefault. home.packages is a list, and the module system's filterOverrides keeps only the highest-priority definitions — so the moment any other module sets home.packages at normal priority (features/scripts/default.nix's `[ nomarchy-scripts ]`, the installer's profile packages), this entire mkDefault list was DROPPED. Every install was silently missing firefox, thunar, imv, mpv, swww, mako, hyprlock, rofi, etc. — which broke notifications (mako never installed → exec-once fails → notify-send dead) and the lock screen (hyprlock missing), and hid a stale `rofi-wayland` reference (merged into `rofi` upstream) that only errored once the list was live again. Remove the mkDefault so the list merges (home.packages = 52 pkgs, up from 31; mako/hyprlock/firefox/… now present) and fix rofi-wayland -> rofi. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This commit is contained in:
@@ -38,7 +38,12 @@ in
|
|||||||
# Enable neovim program module (required for stylix integration)
|
# Enable neovim program module (required for stylix integration)
|
||||||
programs.neovim.enable = lib.mkDefault true;
|
programs.neovim.enable = lib.mkDefault true;
|
||||||
|
|
||||||
home.packages = lib.mkDefault (with pkgs; [
|
# NOT mkDefault: home.packages is a list that MERGES across modules. At
|
||||||
|
# mkDefault priority this whole curated list is dropped the moment any
|
||||||
|
# other module sets home.packages at normal priority (features/scripts,
|
||||||
|
# the installer's profile packages), silently removing firefox, mako,
|
||||||
|
# hyprlock, mpv, etc. — which broke notifications and the lock screen.
|
||||||
|
home.packages = (with pkgs; [
|
||||||
# Core applications
|
# Core applications
|
||||||
firefox
|
firefox
|
||||||
xfce.thunar
|
xfce.thunar
|
||||||
@@ -69,7 +74,7 @@ in
|
|||||||
gum # TUI components for scripts
|
gum # TUI components for scripts
|
||||||
xdg-terminal-exec
|
xdg-terminal-exec
|
||||||
swaybg
|
swaybg
|
||||||
rofi-wayland
|
rofi # rofi-wayland was merged into rofi upstream
|
||||||
|
|
||||||
# Theming — cursor package stays here; icon theme packages are pulled in
|
# Theming — cursor package stays here; icon theme packages are pulled in
|
||||||
# dynamically by themes/engine/stylix.nix via nomarchyLib.iconThemePackage
|
# dynamically by themes/engine/stylix.nix via nomarchyLib.iconThemePackage
|
||||||
@@ -77,3 +82,4 @@ in
|
|||||||
bibata-cursors
|
bibata-cursors
|
||||||
]);
|
]);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|||||||
Reference in New Issue
Block a user