From 1117dcfc37d01579a82fa1b94ee1b90b560a9bb8 Mon Sep 17 00:00:00 2001 From: Bernardo Magri Date: Sun, 31 May 2026 10:40:44 +0100 Subject: [PATCH] =?UTF-8?q?fix(home):=20drop=20mkDefault=20on=20home.packa?= =?UTF-8?q?ges=20=E2=80=94=20it=20discarded=20the=20whole=20app=20list?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Chasing a "DBus.Error … name is not activatable" from notify-send (mako), the root cause turned out to be far bigger: home.packages in features/default.nix was wrapped in lib.mkDefault. home.packages is a list, and the module system's filterOverrides keeps only the highest-priority definitions — so the moment any other module sets home.packages at normal priority (features/scripts/default.nix's `[ nomarchy-scripts ]`, the installer's profile packages), this entire mkDefault list was DROPPED. Every install was silently missing firefox, thunar, imv, mpv, swww, mako, hyprlock, rofi, etc. — which broke notifications (mako never installed → exec-once fails → notify-send dead) and the lock screen (hyprlock missing), and hid a stale `rofi-wayland` reference (merged into `rofi` upstream) that only errored once the list was live again. Remove the mkDefault so the list merges (home.packages = 52 pkgs, up from 31; mako/hyprlock/firefox/… now present) and fix rofi-wayland -> rofi. Co-Authored-By: Claude Opus 4.8 --- features/default.nix | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/features/default.nix b/features/default.nix index de31e06..bb95f76 100644 --- a/features/default.nix +++ b/features/default.nix @@ -38,7 +38,12 @@ in # Enable neovim program module (required for stylix integration) programs.neovim.enable = lib.mkDefault true; - home.packages = lib.mkDefault (with pkgs; [ + # NOT mkDefault: home.packages is a list that MERGES across modules. At + # mkDefault priority this whole curated list is dropped the moment any + # other module sets home.packages at normal priority (features/scripts, + # the installer's profile packages), silently removing firefox, mako, + # hyprlock, mpv, etc. — which broke notifications and the lock screen. + home.packages = (with pkgs; [ # Core applications firefox xfce.thunar @@ -69,7 +74,7 @@ in gum # TUI components for scripts xdg-terminal-exec swaybg - rofi-wayland + rofi # rofi-wayland was merged into rofi upstream # Theming — cursor package stays here; icon theme packages are pulled in # dynamically by themes/engine/stylix.nix via nomarchyLib.iconThemePackage @@ -77,3 +82,4 @@ in bibata-cursors ]); } +