1e9481849b
Sweep across the three script directories: features/scripts/utils,
core/system/scripts, themes/engine/scripts. 142 of 169 bash scripts
gained `set -e`; 27 already had it; the one Python helper
(nomarchy-haptic-touchpad) was skipped via shebang detection.
Why: bash's default behavior is to continue past a failed command,
which means a script that does "do A; do B; do C" leaves the system
in a half-applied state when B fails - and the user gets no signal.
Several recent fix commits (theme partial-apply, waybar reload race,
installer prewipe silent failures) all trace back to this. set -e
turns silent corruption into a loud abort the user can act on.
The 11 scripts with explicit `|| true` markers stay safe under set -e
because || true coerces the exit to zero; the markers continue to
mean "I deliberately tolerate this failure here."
Deliberate exception: nomarchy-menu runs WITHOUT set -e. It is an
interactive UX loop where action branches do `cmd; back_to <self>`
so a failed action would abort the script under set -e and the menu
would disappear without feedback. Soft-failure - menu re-displays,
user picks again - is the right semantic. Documented inline.
Validation: bash -n on every modified script (zero failures). The
new pre-commit hook (27f5663) was just updated to filter by shebang
so it doesn't try to bash-syntax-check the Python helper - that
filter was uncovered by this sweep.
Risk: set -e can surface latent bugs in scripts that previously
relied on silent continuation. If anything breaks, it's a real bug
that was already broken and is now visible. Easy per-script revert
if any UX glitches show up.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
48 lines
1.3 KiB
Bash
Executable File
48 lines
1.3 KiB
Bash
Executable File
#!/bin/bash
|
|
set -e
|
|
|
|
# Share clipboard, file, or folder using LocalSend. Bound to Super + Ctrl + S by default.
|
|
|
|
if (($# == 0)); then
|
|
echo "Usage: nomarchy-cmd-share [clipboard|file|folder]"
|
|
exit 1
|
|
fi
|
|
|
|
MODE="$1"
|
|
shift
|
|
|
|
if [[ $MODE == "clipboard" ]]; then
|
|
TEMP_FILE=$(mktemp --suffix=.txt)
|
|
wl-paste >"$TEMP_FILE"
|
|
FILES="$TEMP_FILE"
|
|
else
|
|
if (($# > 0)); then
|
|
FILES="$*"
|
|
else
|
|
if [[ $MODE == "folder" ]]; then
|
|
# Pick a single folder from home directory
|
|
FILES=$(find "$HOME" -type d 2>/dev/null | fzf)
|
|
else
|
|
# Pick one or more files from home directory
|
|
FILES=$(find "$HOME" -type f 2>/dev/null | fzf --multi)
|
|
fi
|
|
[[ -z $FILES ]] && exit 0
|
|
fi
|
|
fi
|
|
|
|
# Run LocalSend in its own systemd service (detached from terminal)
|
|
# Convert newline-separated files to space-separated arguments
|
|
if [[ $MODE != "clipboard" ]] && echo "$FILES" | grep -q $'\n'; then
|
|
# Multiple files selected - convert newlines to array
|
|
readarray -t FILE_ARRAY <<<"$FILES"
|
|
systemd-run --user --quiet --collect localsend --headless send "${FILE_ARRAY[@]}"
|
|
else
|
|
# Single file or clipboard mode
|
|
systemd-run --user --quiet --collect localsend --headless send "$FILES"
|
|
fi
|
|
|
|
# Note: Temporary file will remain until system cleanup for clipboard mode
|
|
# This ensures the file content is available for the LocalSend GUI
|
|
|
|
exit 0
|