1e9481849b
Sweep across the three script directories: features/scripts/utils,
core/system/scripts, themes/engine/scripts. 142 of 169 bash scripts
gained `set -e`; 27 already had it; the one Python helper
(nomarchy-haptic-touchpad) was skipped via shebang detection.
Why: bash's default behavior is to continue past a failed command,
which means a script that does "do A; do B; do C" leaves the system
in a half-applied state when B fails - and the user gets no signal.
Several recent fix commits (theme partial-apply, waybar reload race,
installer prewipe silent failures) all trace back to this. set -e
turns silent corruption into a loud abort the user can act on.
The 11 scripts with explicit `|| true` markers stay safe under set -e
because || true coerces the exit to zero; the markers continue to
mean "I deliberately tolerate this failure here."
Deliberate exception: nomarchy-menu runs WITHOUT set -e. It is an
interactive UX loop where action branches do `cmd; back_to <self>`
so a failed action would abort the script under set -e and the menu
would disappear without feedback. Soft-failure - menu re-displays,
user picks again - is the right semantic. Documented inline.
Validation: bash -n on every modified script (zero failures). The
new pre-commit hook (27f5663) was just updated to filter by shebang
so it doesn't try to bash-syntax-check the Python helper - that
filter was uncovered by this sweep.
Risk: set -e can surface latent bugs in scripts that previously
relied on silent continuation. If anything breaks, it's a real bug
that was already broken and is now visible. Easy per-script revert
if any UX glitches show up.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
48 lines
1.5 KiB
Bash
Executable File
48 lines
1.5 KiB
Bash
Executable File
#!/bin/bash
|
|
set -e
|
|
|
|
# Toggle to pop-out a tile to stay fixed on a display basis.
|
|
|
|
# Usage:
|
|
# nomarchy-hyprland-window-pop [width height [x y]]
|
|
#
|
|
# Arguments:
|
|
# width Optional. Width of the floating window. Default: 1300
|
|
# height Optional. Height of the floating window. Default: 900
|
|
# x Optional. X position of the window. Must provide both X and Y to take effect.
|
|
# y Optional. Y position of the window. Must provide both X and Y to take effect.
|
|
#
|
|
# Behavior:
|
|
# - If the window is already pinned, it will be unpinned and removed from the pop layer.
|
|
# - If the window is not pinned, it will be floated, resized, moved/centered, pinned, brought to top, and popped.
|
|
|
|
width=${1:-1300}
|
|
height=${2:-900}
|
|
x=${3:-}
|
|
y=${4:-}
|
|
|
|
active=$(hyprctl activewindow -j)
|
|
pinned=$(echo "$active" | jq ".pinned")
|
|
addr=$(echo "$active" | jq -r ".address")
|
|
|
|
if [[ $pinned == "true" ]]; then
|
|
hyprctl -q --batch \
|
|
"dispatch pin address:$addr;" \
|
|
"dispatch togglefloating address:$addr;" \
|
|
"dispatch tagwindow -pop address:$addr;"
|
|
elif [[ -n $addr ]]; then
|
|
hyprctl dispatch togglefloating address:$addr
|
|
hyprctl dispatch resizeactive exact $width $height address:$addr
|
|
|
|
if [[ -n $x && -n $y ]]; then
|
|
hyprctl dispatch moveactive $x $y address:$addr
|
|
else
|
|
hyprctl dispatch centerwindow address:$addr
|
|
fi
|
|
|
|
hyprctl -q --batch \
|
|
"dispatch pin address:$addr;" \
|
|
"dispatch alterzorder top address:$addr;" \
|
|
"dispatch tagwindow +pop address:$addr;"
|
|
fi
|