1e9481849b
Sweep across the three script directories: features/scripts/utils,
core/system/scripts, themes/engine/scripts. 142 of 169 bash scripts
gained `set -e`; 27 already had it; the one Python helper
(nomarchy-haptic-touchpad) was skipped via shebang detection.
Why: bash's default behavior is to continue past a failed command,
which means a script that does "do A; do B; do C" leaves the system
in a half-applied state when B fails - and the user gets no signal.
Several recent fix commits (theme partial-apply, waybar reload race,
installer prewipe silent failures) all trace back to this. set -e
turns silent corruption into a loud abort the user can act on.
The 11 scripts with explicit `|| true` markers stay safe under set -e
because || true coerces the exit to zero; the markers continue to
mean "I deliberately tolerate this failure here."
Deliberate exception: nomarchy-menu runs WITHOUT set -e. It is an
interactive UX loop where action branches do `cmd; back_to <self>`
so a failed action would abort the script under set -e and the menu
would disappear without feedback. Soft-failure - menu re-displays,
user picks again - is the right semantic. Documented inline.
Validation: bash -n on every modified script (zero failures). The
new pre-commit hook (27f5663) was just updated to filter by shebang
so it doesn't try to bash-syntax-check the Python helper - that
filter was uncovered by this sweep.
Risk: set -e can surface latent bugs in scripts that previously
relied on silent continuation. If anything breaks, it's a real bug
that was already broken and is now visible. Easy per-script revert
if any UX glitches show up.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
25 lines
1014 B
Bash
Executable File
25 lines
1014 B
Bash
Executable File
#!/bin/bash
|
|
set -e
|
|
|
|
# Reload waybar in place when it's already running. SIGUSR2 makes waybar
|
|
# re-read its config.jsonc and CSS (including @import-ed files like
|
|
# ~/.config/nomarchy/current/theme/waybar.css that theme-switch rewrites)
|
|
# without destroying its layer-shell surface. A full systemctl restart
|
|
# tears the surface down and creates a new one back-to-back, leaving a
|
|
# frame or two where Hyprland hasn't cleared the dead surface yet — that's
|
|
# the "old on top of new with artifacts" you see after a theme switch on
|
|
# the live ISO.
|
|
if pgrep -x waybar >/dev/null; then
|
|
exec pkill -SIGUSR2 -x waybar
|
|
fi
|
|
|
|
# Not running yet — start it. Prefer the HM systemd user unit
|
|
# (programs.waybar.systemd.enable = true). `systemctl cat` returns
|
|
# non-zero when the unit doesn't exist; `list-unit-files` does not.
|
|
if systemctl --user cat waybar.service >/dev/null 2>&1; then
|
|
exec systemctl --user start waybar.service
|
|
fi
|
|
|
|
# Fallback for systems where waybar isn't managed by systemd.
|
|
nomarchy-restart-app waybar
|