1e9481849b
Sweep across the three script directories: features/scripts/utils,
core/system/scripts, themes/engine/scripts. 142 of 169 bash scripts
gained `set -e`; 27 already had it; the one Python helper
(nomarchy-haptic-touchpad) was skipped via shebang detection.
Why: bash's default behavior is to continue past a failed command,
which means a script that does "do A; do B; do C" leaves the system
in a half-applied state when B fails - and the user gets no signal.
Several recent fix commits (theme partial-apply, waybar reload race,
installer prewipe silent failures) all trace back to this. set -e
turns silent corruption into a loud abort the user can act on.
The 11 scripts with explicit `|| true` markers stay safe under set -e
because || true coerces the exit to zero; the markers continue to
mean "I deliberately tolerate this failure here."
Deliberate exception: nomarchy-menu runs WITHOUT set -e. It is an
interactive UX loop where action branches do `cmd; back_to <self>`
so a failed action would abort the script under set -e and the menu
would disappear without feedback. Soft-failure - menu re-displays,
user picks again - is the right semantic. Documented inline.
Validation: bash -n on every modified script (zero failures). The
new pre-commit hook (27f5663) was just updated to filter by shebang
so it doesn't try to bash-syntax-check the Python helper - that
filter was uncovered by this sweep.
Risk: set -e can surface latent bugs in scripts that previously
relied on silent continuation. If anything breaks, it's a real bug
that was already broken and is now visible. Easy per-script revert
if any UX glitches show up.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
68 lines
2.5 KiB
Bash
Executable File
68 lines
2.5 KiB
Bash
Executable File
#!/bin/bash
|
|
set -e
|
|
|
|
# Switch between audio outputs while preserving the mute status. By default mapped to Super + Mute.
|
|
|
|
focused_monitor="$(hyprctl monitors -j | jq -r '.[] | select(.focused == true).name')"
|
|
|
|
sinks=$(pactl -f json list sinks | jq '[.[] | select((.ports | length == 0) or ([.ports[]? | .availability != "not available"] | any))]')
|
|
sinks_count=$(echo "$sinks" | jq '. | length')
|
|
|
|
if (( sinks_count == 0 )); then
|
|
swayosd-client \
|
|
--monitor "$focused_monitor" \
|
|
--custom-message "No audio devices found"
|
|
exit 1
|
|
fi
|
|
|
|
current_sink_name=$(pactl get-default-sink)
|
|
current_sink_index=$(echo "$sinks" | jq -r --arg name "$current_sink_name" 'map(.name) | index($name)')
|
|
|
|
if [[ $current_sink_index != "null" ]]; then
|
|
next_sink_index=$(((current_sink_index + 1) % sinks_count))
|
|
else
|
|
next_sink_index=0
|
|
fi
|
|
|
|
next_sink=$(echo "$sinks" | jq -r ".[$next_sink_index]")
|
|
next_sink_name=$(echo "$next_sink" | jq -r '.name')
|
|
|
|
next_sink_description=$(echo "$next_sink" | jq -r '.description')
|
|
if [[ $next_sink_description == "(null)" ]] || [[ $next_sink_description == "null" ]] || [[ -z $next_sink_description ]]; then
|
|
# For Bluetooth devices, the friendly name is on the Device entry (device.id), not the Sink entry (object.id)
|
|
device_id=$(echo "$next_sink" | jq -r '.properties."device.id"')
|
|
if [[ $device_id != "null" ]] && [[ -n $device_id ]]; then
|
|
next_sink_description=$(wpctl status | grep -E "^\s*│?\s+${device_id}\." | sed -E 's/^.*[0-9]+\.\s+//' | sed -E 's/\s+\[.*$//')
|
|
fi
|
|
# Fall back to object.id lookup if device.id didn't yield a result
|
|
if [[ -z $next_sink_description ]]; then
|
|
sink_id=$(echo "$next_sink" | jq -r '.properties."object.id"')
|
|
next_sink_description=$(wpctl status | grep -E "\s+\*?\s+${sink_id}\." | sed -E 's/^.*[0-9]+\.\s+//' | sed -E 's/\s+\[.*$//')
|
|
fi
|
|
fi
|
|
|
|
next_sink_volume=$(echo "$next_sink" | jq -r \
|
|
'.volume | to_entries[0].value.value_percent | sub("%"; "")')
|
|
next_sink_is_muted=$(echo "$next_sink" | jq -r '.mute')
|
|
|
|
if [[ $next_sink_is_muted = "true" ]] || (( next_sink_volume == 0 )); then
|
|
icon_state="muted"
|
|
elif (( next_sink_volume <= 33 )); then
|
|
icon_state="low"
|
|
elif (( next_sink_volume <= 66 )); then
|
|
icon_state="medium"
|
|
else
|
|
icon_state="high"
|
|
fi
|
|
|
|
next_sink_volume_icon="sink-volume-${icon_state}-symbolic"
|
|
|
|
if [[ $next_sink_name != $current_sink_name ]]; then
|
|
pactl set-default-sink "$next_sink_name"
|
|
fi
|
|
|
|
swayosd-client \
|
|
--monitor "$focused_monitor" \
|
|
--custom-message "$next_sink_description" \
|
|
--custom-icon "$next_sink_volume_icon"
|