chore(lib): drop dead helpers, document schema boundary #2
Reference in New Issue
Block a user
Delete Branch "wave/qa-lib-schema"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Two unused helpers and a missing comment in the lib/ surface, found
during the Pillar 8 sweep.
readStateinlib/default.nixwas exported but has no externalcallers — only
readHomeStateandreadSystemStateuse itinternally. Removed from the export list; the function stays in the
let-block (still wraps the two public readers).
getWithDefaultinlib/state-schema.nixwas a complete deadfunction: declared as a path-walking fallback helper but never called
anywhere in the tree. core/{system,home}/state.nix use inline
togglesState.<key> or schema.<scope>.<key>instead. Removed.Added a header comment to
lib/state-schema.nixexplaining theschema's boundary — it lists every state.json field consumed by a
Nix option, but state.json may also hold runtime-only fields
(
welcome_donefromnomarchy-welcome) that are intentionallyoff-schema because no Nix option reads them. Future readers will
otherwise think welcome_done is an orphan.
Logged a Later-column roadmap row for consolidating
flake.nix'spalette/themeNames re-imports with
nomarchyLibso the theme list hasone source of truth instead of two.
Two unused helpers and a missing comment in the lib/ surface, found during the Pillar 8 sweep. - `readState` in `lib/default.nix` was exported but has no external callers — only `readHomeState` and `readSystemState` use it internally. Removed from the export list; the function stays in the let-block (still wraps the two public readers). - `getWithDefault` in `lib/state-schema.nix` was a complete dead function: declared as a path-walking fallback helper but never called anywhere in the tree. core/{system,home}/state.nix use inline `togglesState.<key> or schema.<scope>.<key>` instead. Removed. - Added a header comment to `lib/state-schema.nix` explaining the schema's boundary — it lists every state.json field consumed by a Nix option, but state.json may also hold runtime-only fields (`welcome_done` from `nomarchy-welcome`) that are intentionally off-schema because no Nix option reads them. Future readers will otherwise think welcome_done is an orphan. Logged a Later-column roadmap row for consolidating `flake.nix`'s palette/themeNames re-imports with `nomarchyLib` so the theme list has one source of truth instead of two.