fix(themes): #52 broken/high-ROI fidelity fixes
Some checks failed
Check / eval (push) Has been cancelled

Six per-theme defects: rose-pine btop rewritten to Dawn (was Main-on-Dawn,
invisible hi_fg); everforest + summer-night btop inactive_fg off main_bg;
vantablack role inversion (surface/overlay/muted + btop selection);
osaka-jade text↔subtext swap + warn→yellow; catppuccin-latte
mantle/accentAlt/ANSI axis; catppuccin Mocha btop (was Frappé). accentAlt
uses Latte mauve #8839ef, not the audit's pink #ea76cb (which fails the
3.0 contrast floor).

Worktree agent; diff reviewed + contrast conflict adjudicated. V0:
check-theme-contrast 24x7 all pass + flake check green. btop V2 render
pending (batched). Residual ansi[8]/ansi[3] drift noted.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This commit is contained in:
Bernardo Magri
2026-07-09 19:36:58 +01:00
parent 4a99b64532
commit def6e9dcbe
10 changed files with 131 additions and 113 deletions

View File

@@ -110,15 +110,15 @@ theme-shot render with an induced doctor failure to see the glyph (fold into
#44's `checks.doctor` extension); CC message + scroll are behavioural (V1
+ self-evident).
### 52. Theme fidelity bugs — Broken/high-ROI (promoted 2026-07-09, V0+V2)
Execute the six clear per-theme defects — **exact hexes in the
"#### Broken / high-ROI fixes" block under _Per-theme design audit_ below**:
rose-pine btop (Main-on-Dawn → invisible hi_fg; rewrite to Dawn); everforest
+ summer-night btop `inactive_fg==main_bg` (invisible); vantablack role
inversion (white-on-white selection/muted); osaka-jade warn≈good +
text/subtext inverted; catppuccin-latte ANSI black/white axis inverted +
mantle sludge; catppuccin (Mocha) btop is Frappé-on-Mocha. Verify:
`check-theme-contrast` (V0) + a theme-shot render of each (V2).
### 52. Theme fidelity bugs — btop V2 render pending
Six per-theme defects fixed 2026-07-09 (rose-pine btop→Dawn; everforest +
summer-night btop `inactive_fg`; vantablack role inversion; osaka-jade
text/subtext + warn; catppuccin-latte mantle/accentAlt/ANSI; catppuccin
Mocha btop). JSON fixes **V0-verified** (`check-theme-contrast` 24×7 all
pass — accentAlt retuned to Latte mauve `#8839ef`, not the audit's pink
`#ea76cb` which fails the 3.0 floor). **Remaining V2:** a theme-shot render
of the btop-changed themes (rose-pine, everforest, summer-night, vantablack,
catppuccin) — btop.theme isn't contrast-checked.
### 53. Missing theme previews + neon-glass whole-swap (promoted 2026-07-09, V2)
- Capture `executive-slate` + `neon-glass` `preview.png` headlessly via the
@@ -286,6 +286,12 @@ flagged separately from fidelity bugs.*
_→ promoted as NEXT **#52** (2026-07-09); the six bullets below are its
spec (exact hexes). The rest of the per-theme audit stays PROPOSED._
_Residual ANSI drift exposed by the #52 fixes (not yet touched — small
follow-up): **vantablack** `ansi[8]` (bright-black) still `#fdfdfd`, now
diverging from the new `muted #666666`; **osaka-jade** `ansi[3]`
(normal-yellow) still the old warn-green `#459451` while `warn`/`ansi[11]`
are now `#E5C736`. Decide per theme whether these are identity or bugs._
- **rose-pine btop is Main-on-Dawn (near-invisible hi_fg)**
JSON is **Rosé Pine Dawn** (`mode: light`, base `#faf4ed`, text
`#575279`) but `themes/rose-pine/btop.theme` mixes Dawn

View File

@@ -17,6 +17,18 @@ Template:
---
## 2026-07-09 — #52 theme fidelity Broken/high-ROI fixes (delegated, worktree)
- **Task:** NEXT #52. Sonnet worktree agent (parallel, theme files only).
- **Did:** Six defects fixed: rose-pine btop→Dawn, everforest/summer-night
btop `inactive_fg`, vantablack role inversion, osaka-jade text/subtext+warn,
catppuccin-latte mantle/accentAlt/ANSI, catppuccin Mocha btop. **My call on
a flagged conflict:** the audit's accentAlt `#ea76cb` (Latte pink) fails the
3.0 contrast floor → used Latte **mauve `#8839ef`** (contrast-safe, canonical).
- **Verified:** V0 — `check-theme-contrast` 24×7 **all pass**; flake check green.
btop.theme visual = **V2 render pending** (batched). Filed a residual note
(vantablack ansi[8], osaka-jade ansi[3] drift exposed by the fixes).
- **Next:** land #54; batched V2 render of the btop themes + #51 doctor glyph.
## 2026-07-09 — #51 Waybar/menu behaviour bugs (delegated, worktree)
- **Task:** NEXT #51. Sonnet worktree agent (parallel with #52/#54, no shared
files).