fix(menu): #131 — size text menus in ch with a cap, not in % of the monitor
All checks were successful
Check / eval (push) Successful in 3m49s

Bernardo saw Recovery ellipsize on a 2560x1440 external, which falsified
the item's model (40% + Inter 11 → "only below 1920"). Real cause: text
menus render through themes/<slug>/rofi.rasi, where boreal + neon-glass
pinned width: 620px (fixed — a wide panel buys nothing) while seven used
40%, and the font is whatever that file says — mostly monospace, far
wider than the Inter that was measured. The modelled combination ships in
no theme.

The insight: a menu must fit its longest label, which is a count of
characters in the THEME's font — so the window must scale with the font,
not the screen. 40% gives a 1366 panel 546px and a 2560 one 1024px for
the same row, and a 14pt mono theme needs ~25% more room than an 11pt one
on both; a percentage cannot see either fact.

Rofi has the right unit (`ch` = width of one digit in the current font)
and `calc( a min b )` to cap it, so every text menu — generated and all
nine whole-swaps — is now `width: calc( 84ch min 65% )`. 84ch fits the
longest row we ship (69 chars) plus icon and padding; the cap is
Bernardo's condition (never sprawl on a low-res panel) and it is
measured, not assumed.

Verified on hardware, not by arithmetic: 84ch = 756px in GeistMono 11 and
924px in JetBrainsMono 14; `calc( 84ch min 300px )` → 300px, so the clamp
really clamps. Screenshots at both ends — the real Recovery menu at 756px
(29% of 2560) with every label complete, and the Acer worst case
reproduced pixel-exactly (888px = 65% of 1366, JetBrainsMono 14) also
complete. Grid views override width per-invocation and are untouched.
checks.rofi-text-width guards the class, proven by pinning boreal back to
620px and watching it fail by name. Acer V3 queued for its own fontconfig.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This commit is contained in:
2026-07-16 10:20:49 +01:00
parent 39c8b3e0eb
commit 5aad3153ce
15 changed files with 106 additions and 71 deletions

View File

@@ -43,9 +43,16 @@ Template:
so it should hold by construction, which is exactly why it is worth one look.
#131 is **live on 2560** per Bernardo, so its "only at 1366" model is wrong —
next up.
- **Next suggestion:** #131 (recovery labels truncating on a wide panel —
observed, so the measurement in that item is what needs re-doing), then #137
(plymouth per-head) or #142 (rebuild-while-docked).
- **Next suggestion:** #137 (plymouth per-head) or #142 (rebuild-while-docked).
- **Then #131 shipped too (same session):** the remodel found the real cause —
text menus are sized in % of the *monitor* while a label is a count of
*characters* in the *theme's* font, and the whole-swaps disagreed wildly
(620px fixed vs 40%; GeistMono 11 vs JetBrainsMono 14). Fixed with rofi's own
`ch` unit + a `min` cap: `width: calc( 84ch min 65% )` everywhere. Bernardo's
condition ("not ugly on a low-res monitor") is what the cap is for, and it is
measured, not hoped: 84ch = 756px/924px by font, `min 300px` → 300px. V3 by
screenshot at both ends, incl. the Acer's exact geometry reproduced on the dev
box. `checks.rofi-text-width` guards it.
## 2026-07-16 — #138 dock audio: the graph restart was the bug (44aac0f + this)
- **Task:** #138 — Meet "no mic or speakers" in Chromium; Zoom fine; no repro